← Back to team overview

mahara-contributors team mailing list archive

[Bug 1482455] A change has been merged

 

Reviewed:  https://reviews.mahara.org/5090
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/4f5eff808ab083532bf4b4aa857eff270b036999
Submitter: Jono Mingard (reason.koan@xxxxxxxxx)
Branch:    master

commit 4f5eff808ab083532bf4b4aa857eff270b036999
Author: Jono Mingard <jonom@xxxxxxxxxxxxxxx>
Date:   Thu Aug 13 14:30:02 2015 +1200

Update dropdown nav keyboard controls for Bootstrap theme (Bug #1482455)

Dropdown menus now show when they have the 'open' class as well as
on hover, and the dropdown navigation script has been updated to use
the new menu bar classes (and with better code style)

behatnotneeded: doesn't seem to be any good way to fire specific
keyboard events at the page in order to test this

Change-Id: I1bf17183c0510914f16ada7299cfddd6ce29e907
Signed-off-by: Jono Mingard <jonom@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1482455

Title:
  Dropdown menus are no longer keyboard-accessible

Status in Mahara:
  In Progress

Bug description:
  With the introduction of the bootstrap theme, the old JavaScript for
  making the dropdown navigation keyboard accessible no longer seems to
  work. Hopefully that's just because the menus now use different class
  names, so the same script (js/dropdown-nav.js) could be updated with
  those new classes. In any case, this needs to be fixed, since the
  dropdown menus are not at all accessible without this feature.

  Affects latest master

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1482455/+subscriptions


References