mahara-contributors team mailing list archive

[Mahara Bot <1486826@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5156
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/c08c70ba1a62de137c9a7a798dde2bb9e13c80a4
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit c08c70ba1a62de137c9a7a798dde2bb9e13c80a4
Author: Jono Mingard <jonom@xxxxxxxxxxxxxxx>
Date:   Thu Aug 20 16:32:49 2015 +1200

Ignore libraries when checking code style (Bug #1486826)

Files in a directory containing a README.Mahara (or README.mahara)
file should now be ignored by the coding standards checker (and
therefore won't break "make minaccept").

behatnotneeded

Change-Id: Ibb24cb8e923117f1da6d954f4c336abdb5c0b05c

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1486826

Title:
  "make minaccept" should skip code in third-party libraries

Status in Mahara:
  Fix Committed

Bug description:
  Currently, "make minaccept" checks the code style of all changed lines
  in the latest git commit. This is usually a good thing, but falls down
  when a third-party library is added which doesn't follow Mahara's code
  style.

  The current convention for including third-party code is to put it in
  a new directory along with a README.Mahara file, so it would be nice
  if any code in such a directory was ignored by the code style checker.
  This would also remind people to add a README.Mahara along with their
  third party library ...

  Affects latest master

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1486826/+subscriptions