← Back to team overview

mahara-contributors team mailing list archive

[Bug 1491639] A change has been merged

 

Reviewed:  https://reviews.mahara.org/5204
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/192478742a1a0a851cc06e7c32990112a15fe532
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 192478742a1a0a851cc06e7c32990112a15fe532
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Sep 3 11:08:22 2015 +1200

Bug 1491639: 'Group pages' block on upgrade problem

We need to default the 'display shared pages' option to 'By anybody'
value=2 as this is the same rules as the before upgrade.

We can leave newly created groups to default page/collection display to
'By members of this group'.

behatnotneeded

Change-Id: I135e459fecb9ac42e2352e570bc998f6568e2524
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1491639

Title:
  Need to update group 'shared with me' block config values on upgrade
  15.04+

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress

Bug description:
  In pre 15.04 versions Group homepages have a 'Group pages' block
  showing the pages that are shared with the group (a yes/no option).
  This includes pages by members and non-members alike.

  After upgrade to 15.04+ there was a new option added so that we have:
  * None
  * By members of this group
  * By anybody

  But the problem is we added the new option, By members of this group,
  to the '1' value (the same as 'yes' before) rather than to the 'by
  anybody' option (which is '2').

  This means on upgrade any pages shared by non-members stop showing up
  on the shared list for this block.

  We need to run an upgrade for the group homepages to make any 'Display
  shared pages' that were set to 'yes' before hand to be set to 'by
  anybody' so that the same display rules are preserved.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1491639/+subscriptions


References