mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

Public bug reported:

There is a couple of problems with displaying iframes on Mahara.

If one embeds an iframe for a site that can handle only one protocol, eg
http:// or https:// and the Mahara site is using the opposite protocol
then adding the iframe code to the external media block will cause the
block not to load the iframe as it switches the protocol of the iframe
to match the Mahara site.  This is to avoid sites trying to display a
mismatch of both http and https data.

However, if one adds the same iframe to a TinyMCE editor it will display
fine as the TinyMce does not update the iframe to match the Mahara
site's protocol, but uses it 'as is'.

Most sites, eg youtube can resolve both the http and https url fine, but
some sites do not have both protocols sorted out. This is what causes
problems.

To fix these problem we need to do a few things:

1) Make TinyMCE work like external media block and change the iframe
protocol to match the Mahara site protocol - for consistency.

2) But also have a setting in the allowed iframes page (rather than
external media block) indicating whether we want to override the iframe
protocol to match the Mahara site's protocol or not (have default =
override).

That way for sites that don't resolve both http:// and https://
protocols we can say 'respect original iframe code' and it will use the
original iframe url rather than adjusting it.

** Affects: mahara
     Importance: Medium
         Status: Confirmed


** Tags: plugins

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1496162

Title:
  Iframe and url protocol problems

Status in Mahara:
  Confirmed

Bug description:
  There is a couple of problems with displaying iframes on Mahara.

  If one embeds an iframe for a site that can handle only one protocol,
  eg http:// or https:// and the Mahara site is using the opposite
  protocol then adding the iframe code to the external media block will
  cause the block not to load the iframe as it switches the protocol of
  the iframe to match the Mahara site.  This is to avoid sites trying to
  display a mismatch of both http and https data.

  However, if one adds the same iframe to a TinyMCE editor it will
  display fine as the TinyMce does not update the iframe to match the
  Mahara site's protocol, but uses it 'as is'.

  Most sites, eg youtube can resolve both the http and https url fine,
  but some sites do not have both protocols sorted out. This is what
  causes problems.

  To fix these problem we need to do a few things:

  1) Make TinyMCE work like external media block and change the iframe
  protocol to match the Mahara site protocol - for consistency.

  2) But also have a setting in the allowed iframes page (rather than
  external media block) indicating whether we want to override the
  iframe protocol to match the Mahara site's protocol or not (have
  default = override).

  That way for sites that don't resolve both http:// and https://
  protocols we can say 'respect original iframe code' and it will use
  the original iframe url rather than adjusting it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1496162/+subscriptions