mahara-contributors team mailing list archive

[Mahara Bot <1486763@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5228
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/6da147c195499b7a7538929dc712086ae51c74cf
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 6da147c195499b7a7538929dc712086ae51c74cf
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Sep 7 13:51:47 2015 +1200

Bug 1486763: Now deleting correct comment

Was a problem with the old delete button being an image and so passed
the _x value, which was then checked for.

Changed it so it checks that the submit param exists, which is more
robust

behatnotneeded : problem of finding the row that you just deleted as
all deleted rows have the same 'Comment removed by the author' text

Change-Id: Iea379badd2d364112d107977b8f53a62ac272428
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1486763

Title:
  Wrong comment is deleted

Status in Mahara:
  Fix Committed

Bug description:
  master 15.10dev

  Discovered by Pat:

  When you have two comments and want to delete the second one, the
  first one is actually deleted.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1486763/+subscriptions