mahara-contributors team mailing list archive

[Mahara Bot <1495364@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5322
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/fbc76b0665e9f5d026c2dcb19ec762860886dfef
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit fbc76b0665e9f5d026c2dcb19ec762860886dfef
Author: Jen Zajac <jen.zajac@xxxxxxxxxxxxxxx>
Date:   Thu Sep 17 10:07:14 2015 +1200

Reworking skins to work with new theme

behatnotneeded

Bug #1495364

Change-Id: I74045931da05899cdfd33f1950b15e8b270129a8

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1495364

Title:
  Remove compiled CSS from git repository

Status in Mahara:
  In Progress

Bug description:
  With Bug 1465107, the CSS in the core themes is now actually compiled
  from a series of SASS files.

  When we initially started on this, I made the decision to keep the
  compiled CSS in the git repository because I thought it would make
  life easier for our low-tech folks, because they wouldn't have to
  compile the CSS themselves in order to get Mahara to run. And it has
  had this result, but it has also caused immense problems for us devs
  because every time we make a commit that touches one of the SCSS
  files, it gets a merge conflict and cannot be merged cleanly into
  Gerrit.

  Best practice with build products is to exclude them from the gerrit
  repository, and now I'm starting to understand why. ;) So we've
  decided to go ahead and remove the compiled CSS from the gerrit repo.
  But we still want to try to make it easy for people to run Mahara from
  git, without having to understand much about SASS.

  So the plan is:

  1. Add the compiled CSS to the .gitignore file and remove it from the repo.
  2. Add a step to Mahara's makefile, which does everything necessary to build the CSS.
  3. Set up the Jenkins test server to build the CSS before it runs its tests.
  4. Add the build CSS step to the deployment scripts (so that the Mahara zip files for download will still contain compiled CSS)
  5. For people who can't get the CSS build steps to work locally, we set up a web service on one of our servers, which allows you to download the compiled CSS for a given Mahara commit from Gerrit. Something like https://mahara.org/local/getcss.php?id=ae897fd
  6. We add another build step to Mahara's makefile, which detects the current commit, downloads the compiled CSS from the server, and puts it in the right place

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1495364/+subscriptions