mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #29173
[Bug 1498710] Re: Center-align images & videos?
Here's a screenshot illustrating what I'm talking about. The image, and
the embedded video, are left-aligned within their blocks.
The funny thing is, this left-alignment actually looks *better* than
centering, on a single-column page. Because in that case, all the titles
and everything are on the left, so it would be strange if the images and
videos were way off in the middle.
But on a multiple-column page, it looks a little bit strange. Although,
not that bad. So I guess we probably should just leave them left-
aligned.
** Attachment added: "screenshot-uncentered.png"
https://bugs.launchpad.net/mahara/+bug/1498710/+attachment/4471827/+files/screenshot-uncentered.png
** Changed in: mahara
Status: Opinion => Won't Fix
** Changed in: mahara
Milestone: 15.10.0 => None
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1498710
Title:
Center-align images & videos?
Status in Mahara:
Won't Fix
Bug description:
While I was investigating Bug 1496910, I noticed that our Flowplayer
videos are not center-aligned in their block. Instead they're left-
aligned up against the edge of the block.
I was going to submit a patch to fix that, but then I realized that we
do the same for Image blocks as well. If you put up a small image into
a wide image block, the image gets left-aligned within the block.
So, I guess this is a stylistic question. Should we be center-aligning
the content within these blocks? I'd think so, but I'm not entirely
sure because I'm not great at visual things.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1498710/+subscriptions
References