mahara-contributors team mailing list archive

[Mahara Bot <1497411@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5344
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/2389c72b9bdf7e1e893de2192edf67bdbb0e8924
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 2389c72b9bdf7e1e893de2192edf67bdbb0e8924
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Wed Sep 23 17:54:21 2015 +1200

sanitize_url() should return false, when given a null URL (Bug 1497411)

It turns out that if you pass NULL to parse_url(), it returns:
array('path'=>''). Since we were checking isset($parsedurl['path']), this
returns true, even though the url was bad.

behatnotneeded: Already covered by existing tests

Change-Id: I5f4a6074981e6853988225858c22d9dcb0c43feb

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1497411

Title:
  Feed logo image displays a broken image

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress

Bug description:
  If you add a new external RSS feed, it displays the feed but the
  "feedlogoimage" displays a broken image.

  Using:
  - Mahara 15.04.1
  - Windows and OSX
  - MYSQL
  - Firefox (latest version)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1497411/+subscriptions