mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #29272
[Bug 1499150] A change has been merged
Reviewed: https://reviews.mahara.org/5358
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/fd621d412447d7d907f6dff655974ca9914e9c82
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch: master
commit fd621d412447d7d907f6dff655974ca9914e9c82
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date: Thu Sep 24 15:26:40 2015 +1200
Bug 1499150: Allow anonymous author link to work via ajax
Change-Id: I84f2d3336a91761827b54c55d1dd1ef9aef75a69
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1499150
Title:
Anonymous author link not working
Status in Mahara:
Fix Committed
Bug description:
Now that we load some blocks via ajax the 'Allow anonymous pages' is
not working right
When you are an admin and a user has made their page have anonymous
author you see a link with ' (Author's name hidden) ' instead of name.
On clicking that link it should show you the actual name, but it
doesn't.
Things broken:
1) The js is not working for the ' (Author's name hidden) ' links when
block loaded via ajax
2) The js is not working right if there are two blocks on a page
showing pages with author = ' (Author's name hidden) ' as each one
sets an id to use from a loop and so the id's are doubled.
The way this was implemented for the templates was a bit overblown.
Instead of trying to assign the index via the parent template then
declare it in author.tpl and also include the author.js via the
smarty, we can just do a js snippet in the author.tpl and call
get_random_key() instead.
This way things are easier to understand and the js will function with
ajax load
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1499150/+subscriptions
References