mahara-contributors team mailing list archive

[Mahara Bot <1496683@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5307
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/9a28149b663ab68810c6272d55bf525738cb5e7c
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 9a28149b663ab68810c6272d55bf525738cb5e7c
Author: Jono Mingard <jonom@xxxxxxxxxxxxxxx>
Date:   Thu Sep 17 17:26:18 2015 +1200

Ensure pieforms labels are always escaped (Bug #1496683)

Remove the 'labelescaped' attribute entirely since it doesn't look
like that was being used for anything vital.

behatnotneeded

Change-Id: Ibab70cfdf04862ff364d10d0cf8d49ae37e39858

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1496683

Title:
  Unescaped 'title' strings used in pieforms elements

Status in Mahara:
  Fix Committed

Bug description:
  Normally when an element's 'title' attribute is rendered (eg. into a
  label) it is HTML-escaped. However, there are still a few places where
  it isn't, so putting HTML in the label's language string can mess up
  some pages. This should probably be escaped everywhere it's used (to
  be consistent).

  To complicate things, there's an optional 'labelescaped' attribute
  that can be added to elements which (contrary to the name) means the
  label *shouldn't* be escaped.

  Affects latest master

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1496683/+subscriptions