← Back to team overview

mahara-contributors team mailing list archive

[Bug 1497411] A change has been merged

 

Reviewed:  https://reviews.mahara.org/5317
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/c6e09db153e38da7bc6f1766e6419c3051d15ef9
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    15.04_STABLE

commit c6e09db153e38da7bc6f1766e6419c3051d15ef9
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Wed Sep 23 17:54:21 2015 +1200

sanitize_url() should return false, when given a null URL (Bug 1497411)

It turns out that if you pass NULL to parse_url(), it returns:
array('path'=>''). Since we were checking isset($parsedurl['path']), this
returns true, even though the url was bad.

behatnotneeded: Already covered by existing tests

Change-Id: I6ecb2468537b4754a35c76e3a4ee4a6ef6078229

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1497411

Title:
  Feed logo image displays a broken image

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed

Bug description:
  If you add a new external RSS feed, it displays the feed but the
  "feedlogoimage" displays a broken image.

  Using:
  - Mahara 15.04.1
  - Windows and OSX
  - MYSQL
  - Firefox (latest version)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1497411/+subscriptions


References