mahara-contributors team mailing list archive

[Aaron Wells <1495200@xxxxxxxxxxxxxxxxxx>]

The root of this problem is that we're serializing the login Pieform
object and storing it in the session. This was done in this patch:
https://reviews.mahara.org/#/c/2980/5/htdocs/auth/lib.php

Since that patch was added in Mahara 1.9, this problem is probably
present in all versions of Mahara since then.

Probably, what we should be doing is *not* serializing the entire login
form object, but just portions of it that are made out of PHP primitives
(strings, arrays, etc).

** Also affects: mahara/15.10
   Importance: Medium
       Status: New

** Also affects: mahara/16.04
   Importance: Undecided
       Status: New

** Changed in: mahara/16.04
    Milestone: None => 16.04.0

** Changed in: mahara/16.04
   Importance: Undecided => Medium

** Changed in: mahara/15.10
   Importance: Medium => High

** Changed in: mahara/16.04
   Importance: Medium => High

** Changed in: mahara/15.10
       Status: New => Confirmed

** Changed in: mahara/16.04
       Status: New => Confirmed

** Also affects: mahara/1.10
   Importance: Undecided
       Status: New

** Also affects: mahara/15.04
   Importance: Undecided
       Status: New

** Also affects: mahara/1.9
   Importance: Undecided
       Status: New

** Changed in: mahara/1.9
       Status: New => Won't Fix

** Changed in: mahara/15.04
       Status: New => Confirmed

** Changed in: mahara/1.10
       Status: New => Confirmed

** Changed in: mahara/15.04
   Importance: Undecided => High

** Changed in: mahara/1.9
   Importance: Undecided => High

** Changed in: mahara/1.10
   Importance: Undecided => High

** Changed in: mahara/1.9
       Status: Won't Fix => Confirmed

** Changed in: mahara/15.04
    Milestone: None => 15.04.4

** Changed in: mahara/1.9
    Milestone: None => 1.9.9

** Changed in: mahara/1.10
    Milestone: None => 1.10.7

** Tags added: regression

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1495200

Title:
  White screen when session times out

Status in Mahara:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed

Bug description:
  Issue with 15.10

  If you are logged into mahara and leave the site open in a browser for
  some time when you come back and try to navigate somewhere you can end
  up with a white blank screen - on refresh of page all works fine.

  The problem is this:
  PHP Fatal error:  auth_generate_login_form(): The script tried to execute a method or access a property of an incomplete object. Please ensure that the class definition "Pieform" of the object you are trying to operate on was loaded _before_ unserialize() gets called or provide a __autoload() function to load the class definition  in /home/robertl/htdocs/mahara-devel/mahara/htdocs/auth/lib.php on line 1945

  Which deals with the line:
  return get_login_form_js($SESSION->loginform->build());

  In earlier Mahara you would instead be given (via js) a popup login
  box.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1495200/+subscriptions