mahara-contributors team mailing list archive

[Mahara Bot <1486699@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5435
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/d6af8c863fb020477dfe95b155d6f639704c0568
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    1.9_STABLE

commit d6af8c863fb020477dfe95b155d6f639704c0568
Author: Kevin Rickis <rdx565@xxxxxxxxx>
Date:   Mon Aug 24 09:34:22 2015 +1200

Bug 1486699: get_new_username() truncating username badly for SAML

Ends up with username in auth_remote_user being different to the
username in usr table.

behatnotneeded

Change-Id: If6a5a18360ef82da2e3a709899e7d4d1624e8fab
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit dc3b3292415b17730e809afc0a9bfd80decd19a8)
(cherry picked from commit 884b9f71d4479cb604ee071e32ec7480ac3ed203)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1486699

Title:
  Username character limit preventing login via SAML

Status in Mahara:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.9 series:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress

Bug description:
  Mahara version15.04.1

  This report is in relation to my earlier forum post
  https://mahara.org/interaction/forum/topic.php?id=7310 but I have
  tracked down the problem.

  Issue:

  User is logging in via SAML and the user is being auto-created on first login.
  Remote  username is a unique id  (example: 51c717bc-425c-4b31-9674-d38ba03b4f1f)
  When the user tries subsequent logins they are rejected with a error message that the user already exists and cannot be created.

  Reason:

  When the user is auto-created only the first 30 characters of the unique id are stored in the username field so the user is not recognised as being on the system when cheaked agains the full username from the login.
  The system then tries to auto-create the user, which fails because the full unique id is stored in the 'auth_remote_user' table.

  Solution:

  Changing  $maxlen  from 30 to 40 in function get_new_username() of
  user.php populates the user name with the full unique id.

  Maybe this could be a configurable option?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1486699/+subscriptions