mahara-contributors team mailing list archive

[Mahara Bot <1487464@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5437
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/0ac92e839662e22d6913a24609633ee19a46cfe1
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    1.10_STABLE

commit 0ac92e839662e22d6913a24609633ee19a46cfe1
Author: Kevin Rickis <rdx565@xxxxxxxxx>
Date:   Mon Aug 24 09:50:47 2015 +1200

Bug 1487464: SAML creating new email artefact on login

Problem is the dealing with the email artefact type happens after the check
for is_singular(), which 'email' artefact type is not.

behatnotneeded

Change-Id: I4d1ffbb2fb89cc705bf3e2e6211f22e24ca55b26
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 4eec36102eadf8da684806afe5600e79e28e7737)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487464

Title:
  SAML Update user details on login option creating new email artefact
  on every login

Status in Mahara:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.9 series:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress

Bug description:
  Mahara version: 15.04.1

  Issue: When a user logs in via SAML and the configuration option is
  set to update the user's details then a new email artefact is created
  every time.

  I think I have traced the problem

  saml/lib.php line #234 calls set_profile_field($user->id, 'email',
  $email);

  lib/user.php lines #511-516 are a try{} in which  $email =
  artefact_instance_from_type('email', $userid); is called.

  This fails with the message "This artefact type is not a 'singular'
  artefact type" and so a new email artefact is created.

  It will always fail because artefact/internal/lib.php lines #705-708
  returns false for is_singular()

  class ArtefactTypeEmail extends ArtefactTypeProfileField {
      public static function is_singular() {
          return false;
      }

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487464/+subscriptions