mahara-contributors team mailing list archive

[Mahara Bot <1487815@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5587
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/12660c46256cb2964c35a0740bf6f8c815624f0c
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    15.10_STABLE

commit 12660c46256cb2964c35a0740bf6f8c815624f0c
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Oct 20 13:53:45 2015 +1300

Bug 1487815: Dealing with missing theme select box error

On site config page after upgrade some themes will not exist anymore
so we need to reset the theme to the default theme whatever that is
and alert the user about this.

We also need to set institution theme to sitedefault if their set theme
has gone.

behatnotneeded

Change-Id: I9459a920f1d870b71a9a0d48cc0ed39761152143
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit f62cafd8da4cf4c1512c966dd9f6fbb54cc898e5)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487815

Title:
  Error message when theme cannot be found

Status in Mahara:
  In Progress

Bug description:
  on master 15.10dev

  To test:

  1. Install Mahara 15.04
  2. Change the site theme to a theme that is not "Raw" or "Default".
  3. Upgrade the site to the latest master.

  When logging back into the site, I get the following warning when I'm
  on "Configure site" -> "Site options":

  [WAR] dd (lib/pieforms/pieform.php:1314) Invalid value for select "theme"
  Call stack (most recent first):

      log_message("Invalid value for select "theme"", 8, true, true, "/home/kristina/code/mahara/htdocs/lib/pieforms/pie...", 1314) at /home/kristina/code/mahara/htdocs/lib/errors.php:441
      error(1024, "Invalid value for select "theme"", "/home/kristina/code/mahara/htdocs/lib/pieforms/pie...", 1314, array(size 2)) at Unknown:0
      trigger_error("Invalid value for select "theme"", 1024) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1314
      Pieform::info("Invalid value for select "theme"") at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform/elements/select.php:143
      pieform_element_select(object(Pieform), array(size 13)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1480
      Pieform->build_element_html(array(size 13)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:709
      Pieform->build() at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:169
      Pieform::process(array(size 7)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:71
      pieform(array(size 7)) at /home/kristina/code/mahara/htdocs/admin/site/options.php:774

  
  The old theme cannot be found (correct), but also the value can't be found.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487815/+subscriptions