mahara-contributors team mailing list archive

[Mahara Bot <1489284@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5606
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/7a7754ec0435131d72858dc1d7ebfa0d0d25a31c
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    15.10_STABLE

commit 7a7754ec0435131d72858dc1d7ebfa0d0d25a31c
Author: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>
Date:   Mon Sep 7 10:04:35 2015 +1200

Handle embedded image deletion better. Bug 1489284

Refactor updating embedded images

Deals with the deleting of embedded images in a:
- blog
- forum post
- forum topic
- group description
- note
- page description

Also sorts out the problem where a note embedded item can be saved
with both 'editnote' and 'textbox' resourcetype. We only need one.

Also add 'static' to EmbeddedImage::methods()

behatnotneeded

Change-Id: Ife1f9dee5ffe9eae4468eadb8f46a16a0a2a9044

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1489284

Title:
  Warning message when deleting a blog

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress

Bug description:
  I noticed this warning message when deleting a journal. I'm not sure
  whether the journal has to have embedded images in an entry or not,
  but here's what I did.

  1. Create a journal
  2. Create a journal entry
  3. Use the TinyMCE image button to embed an image in the journal entry
  4. Select the journal entry in a journal entry block on a page
  5. Delete the page
  6. Delete the journal

  Result:

  [WAR] 75 (lib/embeddedimage.php:176) Invalid argument supplied for foreach()
  Call stack (most recent first):

      log_message("Invalid argument supplied for foreach()", 8, true, true, "/home/aaronw/www/mahara/htdocs/lib/embeddedimage.p...", 176) at /home/aaronw/www/mahara/htdocs/lib/errors.php:441
      error(2, "Invalid argument supplied for foreach()", "/home/aaronw/www/mahara/htdocs/lib/embeddedimage.p...", 176, array(size 3)) at /home/aaronw/www/mahara/htdocs/lib/embeddedimage.php:176
      EmbeddedImage::delete_embedded_images("blog", "58") at /home/aaronw/www/mahara/htdocs/artefact/blog/index.php:56
      delete_blog_submit(object(Pieform), array(size 3)) at Unknown:0
      call_user_func_array("delete_blog_submit", array(size 2)) at /home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:532
      Pieform->__construct(array(size 4)) at /home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:162
      Pieform::process(array(size 4)) at /home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:71
      pieform(array(size 4)) at /home/aaronw/www/mahara/htdocs/artefact/blog/lib.php:461
      ArtefactTypeBlog::delete_form(58) at /home/aaronw/www/mahara/htdocs/artefact/blog/index.php:28

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1489284/+subscriptions