mahara-contributors team mailing list archive

[Aaron Wells <1513276@xxxxxxxxxxxxxxxxxx>]

So, currently iframe sources are set up at install time by a list in
core_postinst().

Except the prezi one, which was added later and is installed via the
postinst() method of the externalvideo blocktype.

And the youtube-nocookie.com one was added to the externalvideo
blocktype *upgrade*, but not to either installer.

It's not great that these things are scattered everywhere, because it
makes it hard for devs to know where to look when they're doing
something as simple as adding a new allowed iframe source. Technically
speaking, allowed iframe sources are not the domain of *any* specific
plugin. They're used by everything that uses TinyMCE, as well as the
externalvideo block (and maybe some other places?). I guess we could
make them into a dependency of pieforms, or make them into their own
module.

But it would be a good (easy) start at least, if we put them all into
the externalvideo postinst, or into core_postinst().

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1513276

Title:
  Consolidate the iframe sources code

Status in Mahara:
  In Progress

Bug description:
  Currently we do a bunch of different things to add allowed iframe
  sources code to the system when we install/upgrade a site

  We need to make it one way only

  Notes:
  lib/upgrade.php, core_postinst(), has a hard-coded list of allowed iframe sources
  if you add the youtube-no-iframes one there, can you also move the prezi one there, and take it out from blocktype/externalvideo::postinst() ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1513276/+subscriptions