mahara-contributors team mailing list archive

[Mahara Bot <1512942@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5655
Committed: https://git.mahara.org/mahara/mahara/commit/c75120b4d2d22433653e38e19368bb0c30dfac31
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit c75120b4d2d22433653e38e19368bb0c30dfac31
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Wed Nov 4 17:51:04 2015 +1300

Use the right artefact API for group journal tab (Bug 1512942)

Also fixing a long-standing unnoticed bug in the group menu
method. Each item has a "weight", but the items are never
sorted by weight. They were just used in the order they were
inserted, which coincidentally matched their weight order.

behatnotneeded: Results won't be visible from the front-end

Change-Id: Ib56aaedfd494401336fb11443ce6495f6dfe4cb5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1512942

Title:
  Group journals tab isn't using the proper API

Status in Mahara:
  Fix Committed

Bug description:
  While investigating some group-related issues, I noticed that the new
  group journals tab was hard-coded into the group_get_menu_tabs()
  method, instead of using the PluginArtefact::group_tabs() api method
  (like the Files artefact does).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1512942/+subscriptions