mahara-contributors team mailing list archive

[Mahara Bot <1513611@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5665
Committed: https://git.mahara.org/mahara/mahara/commit/6353a366818070114126e845a309a1b86a209164
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 6353a366818070114126e845a309a1b86a209164
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Nov 6 09:34:37 2015 +1300

Bug 1513611: Artefactchooser template is broken for some systems

I can't replicate but believe it's due to the .tpl file compiling
to a call to empty() with an expression as the parameter (which
is not supported by PHP prior to 5.5)

behatnotneeded: covered by existing tests

Change-Id: Ic44b89070de169790dbc5ab6d32a12484925c7e3
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1513611

Title:
  Problem with artefactchooser and dwoo template

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  A couple of people have reported this problem, on of which is here:

  https://mahara.org/interaction/forum/topic.php?id=7426&offset=0&limit=10#post29848

  The error they get is: PHP Parse error: syntax error, unexpected '('
  in
  /path/to/dwoo/compile/raw/var/www/mahara-15.10.0/htdocs/theme/raw/templates/form/artefactchooser.tpl.d17.php
  on line 39

  The line looks to be syntax correct and works fine on my machine
  (Ubuntu 14.04, firefox, PHP 5.5.9)

  But we could try and fix this issue by removing the empty() function
  from the template htdocs/theme/raw/templates/form/artefactchooser.tpl
  and place it in the htdocs/lib/form/elements/artefactchooser.php file
  instead to see if that makes a difference.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1513611/+subscriptions