mahara-contributors team mailing list archive

[Aaron Wells <1516823@xxxxxxxxxxxxxxxxxx>]

Hugh has already submitted a patch for this:
https://reviews.mahara.org/#/c/5704/

This patch works in concert with this code change to the assignment
submission plugin: https://github.com/MaharaProject/moodle-
assignsubmission_mahara/pull/19

And due to a bug in Moodle core that prevents second-level plugin types
like "assign/submission" from registering MNet methods, this plugin also
either requires a Moodle patch, or a separate top-level plugin to
register the MNet method. Since we're not sure how long it will take
Moodle to merge such a patch, or whether they'll be willing to backport
it to the current stable Moodle releases, we've pursued both methods
simultaneously:

1. Moodle patch: https://tracker.moodle.org/browse/MDL-52172
2. Re-awakened Mahara local plugin:  https://github.com/catalyst/moodle-local_mahara/commit/177a8b8970884b65967c4d5c15ed49d6849243fd

Everything should be backwards-compatible, so that a new version of the
plugin will work with an old version of Mahara, and vice versa. If the
changes have an acceptably low risk profile, then we should backport
them to all the stable versions of Mahara. If this doesn't look like a
good idea, then we can instead update the patch file that comes with the
plugin.

Setting priority to "low" because this only affects sites that are using
the Moodle assignment submission plugin, and only under certain use
cases.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1516823

Title:
  MNet: Separate the acts of locking a page, and granting view access to
  a page

Status in Mahara:
  In Progress
Status in Mahara 16.04 series:
  In Progress

Bug description:
  See also: https://github.com/MaharaProject/moodle-
  assignsubmission_mahara/issues/2

  The Mahara assignment submission plugin was originally written with
  the idea that submitted pages would always be locked. So, we used the
  presence of the lock record as a way to check for whether or not the
  page should be visible to a specific MNet user.

  With the new generation assignment submission plugin, the plugin now
  supports modes of operation where the Mahara page *never* gets locked.
  In this case, it was relying on a bug in the original code, where the
  view access record would remain present after you locked & unlocked a
  page, until another submission instance came along and subsequently
  locked the page.

  To handle this in a more correct manner, we need separate methods for
  locking a page, and for checking whether a user has access to a page.
  The way we've decided to handle this, is to delegate the access
  control to Moodle. When a user comes from the Moodle gradebook to view
  a submitted Mahara page, Mahara will make an MNet function call back
  to Moodle to check whether that user should be able to view that page
  or not. This will replace the current confused system of secret URL
  tokens and locks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1516823/+subscriptions