← Back to team overview

mahara-contributors team mailing list archive

[Bug 1517228] A change has been merged

 

Reviewed:  https://reviews.mahara.org/5733
Committed: https://git.mahara.org/mahara/mahara/commit/e9584a54cc890b3f9bd0ba7cab57b600a4a836a2
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit e9584a54cc890b3f9bd0ba7cab57b600a4a836a2
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Nov 18 11:29:16 2015 +1300

Bug 1517228: perf_to_log function amd misisng data

Because some systems may not have all the available data we should
check if the data exists before trying to display it.

To test:
Before patch change the line in lib/mahara.php
if (function_exists('posix_times')) {
to
if (!function_exists('posix_times')) {

and make sure the 'perf_to_log' config option is set to true

This will cause the errors we are trying to deal with to show up

behatnotneeded

Change-Id: If9610fa0eaf4c8bb036b21c1c75e10d828de7934
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1517228

Title:
  Undefined index: ticks

Status in Mahara:
  Fix Committed

Bug description:
  There is a function in mahara called perf_to_log which retrieves some
  performance information from get_performance_info(), turns it to a
  string and adds the string to log file.

  But there is a problem with it.

  the get_performance_info() does a check for things but the perf_to_log
  expects all options to exist.

  This is annoying as it fills up the error log with crud we don't need

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1517228/+subscriptions


References