mahara-contributors team mailing list archive

[Aaron Wells <1510421@xxxxxxxxxxxxxxxxxx>]

The patch will automatically look for the old "thumb.png" file, so it
should be automatically compatible with block plugins that haven't been
upgraded for 15.10.

It also provides 3rd-party developers with the option to name a specific
FontAwesome icon they want to use for their block.

The easiest way to test it, is to install a 3rd-party plugin using the
old & the new method. I've updated my Clippy blocktype with a couple of
branches for this purpose:

Clippy with the "legacy" thumb.png: https://github.com/agwells
/maharacontrib-blocktype-clippy/archive/Bug1510421-thumbnail.zip

Clippy with a FontAwesome icon (a paperclip): https://github.com/agwells
/maharacontrib-blocktype-clippy/archive/Bug1510421-fontawesome.zip

To test:

1. Install Mahara
2. Download the clippy plugin with the legacy thumbnail, and install it into htdocs/blocktype/clippy
3. Go to the admin screen and install the clippy plugin
4. Log in to Mahara and edit a page. Look for the clippy icon in the "General" blocks category. You should see the small, in-color Clippy icon.
5. Delete the contents from htdocs/blocktype/clippy and replace them with the version of clippy with a FontAwesome icon
6. Log back in to Mahara and edit a page. Look for the clippy icon in the "General" blocks category. You should see a black-and-white FontAwesome paperclip icon.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1510421

Title:
  Better support for 3rd party blocktype icons in Mahara 15.10+

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  In Progress

Bug description:
  As discussed in the Mahara dev meeting. With the new bootstrap themes,
  Mahara core blocktypes now use fontawesome for their icons.
  Consequently the template that displays each block in the block
  picker, is no longer using the old thumb.png or get_icon() mtehods to
  get the block's icon and display it. Instead, it just has a <span>
  with a class "icon-{blocktype.name}":

  https://git.mahara.org/mahara/mahara/blob/master/htdocs/theme/raw/templates/view/blocktypelist.tpl

  These are then mapped to fontawesome classes here:

  https://git.mahara.org/mahara/mahara/blob/master/htdocs/theme/raw/sass/typography/_icons.scss#L21

  It would make sense for us to support the old methods, and we could
  make the system do this automatically, with some logic in
  blocktypelist.tpl and/or in htdocs/blocktype/lib.php

  For now, the workaround is to create a style.css file for the block
  (under the block's own theme directory) and define the class in there,
  like this example from the clippy block: https://github.com/agwells
  /maharacontrib-blocktype-
  clippy/blob/master/theme/raw/static/style/style.css

   .icon-clippy::before {
       content: url(\../images/thumb.png);
   }

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1510421/+subscriptions