mahara-contributors team mailing list archive

[Aaron Wells <1519516@xxxxxxxxxxxxxxxxxx>]

I wrote up a quick patch for this: https://reviews.mahara.org/#/c/5767/

But the results weren't really "fixed". The upgrade ran fine (I did it
from the CLI; didn't try the web-based upgrader), but the CSS on the
site was 90% broken. It looks like this is because the old theme
"static/style" directories were still there, and the Theme code checks
in that location before checking for the new base "style" directory
where the real theme files were. So I had 15.10 HTML, with 15.04 CSS,
and few of the styles matched up and worked correctly.

Ignoring that, I logged in anyway and went to the admin screen. There,
the upgrader asked me to upgrade the multirecipient module, and install
the multirecipient artefact! Which, of course it would, because we
essentially uninstall the multirecipient artefact during upgrade, but
since its files are still in place, that prompts Mahara to ask you to
re-install it.

So I'm abandoning that patch because it doesn't really solve the problem
and may, in fact, cause more problems.

I'll see about making sure the upgrade documentation is correct,
instead.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1519516

Title:
  Upgrade to 15.10 fails for sites that have upgraded Mahara by copying
  over their existing installation

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  In Progress

Bug description:
  I've now encountered two users on the support forums who had issues
  upgrading because they had copied over their existing Mahara site, and
  now have duplicate methods defined in the (old) multirecipient
  artefact plugin and the (new) multirecipient module plugin:

  https://mahara.org/interaction/forum/topic.php?id=7438&offset=0&limit=10#post29970

  https://mahara.org/interaction/forum/topic.php?id=7444&offset=0&limit=10#post29986

  This was caused because in Bug 1468156, we refactored this plugin from
  an artefact to a module. Apparently some users upgrade their sites
  through this process:

  1. Download & unzip the new release
  2. Copy the release into their existing Mahara webroot
  3. When prompted, replace existing files in the webroot with new versions from the zip.

  The problem is this leaves the old files in place. Thus far, this
  approach has not caused any crashes, though I imagine it might lead to
  some strange behaviors, like possibly extra CSS files getting loaded,
  and the redundant ContactInfo block still being around. But the
  multirecipient module is perhaps the first case of us moving a library
  file from one location to another, and that results in the user having
  two library files that define some methods with the same name, and
  that causes a fatal PHP error.

  Since this has been common enough to come up twice in the forum, it
  would probably be a good idea to address it somehow.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1519516/+subscriptions