← Back to team overview

mahara-contributors team mailing list archive

[Bug 1520067] Re: Institution blog pagination broken when you first visit the Institution Journals page

 

The patch can break things if there are no institutions yet created and
you try and go to the Institution -> Journals page.

I've updated the patch to deal with that issue

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1520067

Title:
  Institution blog pagination broken when you first visit the
  Institution Journals page

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  In Progress

Bug description:
  This patch ( https://reviews.mahara.org/#/c/5784/3 ) fixes institution
  blog pagination. But! When you first go to the Administration ->
  Institutions -> Journals, pagination is still broken. This is because
  on first loading the page, we have the query param "institution=1".
  The artefact/blog/index.php page passes this to
  institution_selector_for_page(), which understands "1" to mean "show
  me the default first institution".

  But, the paginator JS automatically also takes this "1" from the query
  and passes it to the paginator script artefact/blog/index.json.php.
  And that script doesn't know what to do with it, so it crashes and
  says "A required parameter is missing or malformed The 'institution'
  parameter is not alphabetical only".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1520067/+subscriptions


References