mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #31971
[Bug 1524601] [NEW] Speed up minaccept by only linting changed files
Public bug reported:
"make push" takes a long time to finish on my computer. On my laptop at
home, just one small change takes about 48 seconds to run through
minaccept. I've found myself more frequently just doing "git push gerrit
HEAD:refs/publish/master" rather than waiting for it to finish.
So, I decided to see if I could speed things up. And it seems the
biggest use of time in the minaccept is that it runs "php -l" on every
PHP file in htdocs, not just the ones that have changed. Same for
xmllint on all the XML files, but that's not as big of a problem because
there aren't as many of them.
** Affects: mahara
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1524601
Title:
Speed up minaccept by only linting changed files
Status in Mahara:
New
Bug description:
"make push" takes a long time to finish on my computer. On my laptop
at home, just one small change takes about 48 seconds to run through
minaccept. I've found myself more frequently just doing "git push
gerrit HEAD:refs/publish/master" rather than waiting for it to finish.
So, I decided to see if I could speed things up. And it seems the
biggest use of time in the minaccept is that it runs "php -l" on every
PHP file in htdocs, not just the ones that have changed. Same for
xmllint on all the XML files, but that's not as big of a problem
because there aren't as many of them.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1524601/+subscriptions
Follow ups
-
[Bug 1524601] Re: Speed up minaccept by only linting changed files
From: Kristina Hoeppner, 2016-04-30
-
[Bug 1524601] Re: Speed up minaccept by only linting changed files
From: Aaron Wells, 2016-03-23
-
[Bug 1524601] Re: Speed up minaccept by only linting changed files
From: Son Nguyen, 2016-03-23
-
[Bug 1524601] Re: Speed up minaccept by only linting changed files
From: Robert Lyon, 2016-03-23
-
[Bug 1524601] A change has been merged
From: Mahara Bot, 2015-12-13
-
[Bug 1524601] Re: Speed up minaccept by only linting changed files
From: Robert Lyon, 2015-12-13
-
[Bug 1524601] A patch has been submitted for review
From: Mahara Bot, 2015-12-11
-
[Bug 1524601] A change has been merged
From: Mahara Bot, 2015-12-11
-
[Bug 1524601] A change has been merged
From: Mahara Bot, 2015-12-11
-
[Bug 1524601] A patch has been submitted for review
From: Mahara Bot, 2015-12-11
-
[Bug 1524601] A patch has been submitted for review
From: Mahara Bot, 2015-12-11
-
[Bug 1524601] Re: Speed up minaccept by only linting changed files
From: Robert Lyon, 2015-12-11
-
[Bug 1524601] A change has been merged
From: Mahara Bot, 2015-12-11
-
[Bug 1524601] Re: Speed up minaccept by only linting changed files
From: Aaron Wells, 2015-12-10
-
[Bug 1524601] A patch has been submitted for review
From: Mahara Bot, 2015-12-10