mahara-contributors team mailing list archive

[Aaron Wells <1532642@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

In 15.10 we switched to using fontawesome icons to display the icons for
blocktypes. Prior to that, we relied on a file called "thumb.png" under
each blocktype's image directory (or under the corresponding directory
in the theme).

Through an oversight, we left these images in place in Mahara 15.10. In
15.10.0 they were basically useless. In 15.10.1, after the patch for Bug
1510421, they become potentially useful because we began providing both
the FontAwesome icon name *and* the thumb.png path to
view/blocktypelist.tpl, so a third-party theme could in theory start
using them if they wanted to use all .png files for the block picker
rather than CSS icons.

However, since we're no longer using these icons in the core themes,
they are likely to fall out of support, so we should probably just
delete theme from core.

If we do this:

1. Third-party plugins can still provide a thumb.png file (for
backwards-compatibility with older plugins, or for plugins that have no
suitable icon in FontAwesome)

2. Third-party theme developers can still provide their own thumb.png
files for the core blocktypes if they wish. They'll just need to place
them under their own theme directory (i.e.
/theme/CUSTOMTHEME/plugintypes/blocktype/clippy/images/thumb.png)

So it won't have any effect on what third-party devs can do. It'll just
remove some unused and unmaintained image files from the core Mahara
distribution.

** Affects: mahara
     Importance: Low
     Assignee: Aaron Wells (u-aaronw)
         Status: In Progress


** Tags: blocktype images png theming

** Changed in: mahara
    Milestone: None => 16.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1532642

Title:
  Remove old thumb.png files

Status in Mahara:
  In Progress

Bug description:
  In 15.10 we switched to using fontawesome icons to display the icons
  for blocktypes. Prior to that, we relied on a file called "thumb.png"
  under each blocktype's image directory (or under the corresponding
  directory in the theme).

  Through an oversight, we left these images in place in Mahara 15.10.
  In 15.10.0 they were basically useless. In 15.10.1, after the patch
  for Bug 1510421, they become potentially useful because we began
  providing both the FontAwesome icon name *and* the thumb.png path to
  view/blocktypelist.tpl, so a third-party theme could in theory start
  using them if they wanted to use all .png files for the block picker
  rather than CSS icons.

  However, since we're no longer using these icons in the core themes,
  they are likely to fall out of support, so we should probably just
  delete theme from core.

  If we do this:

  1. Third-party plugins can still provide a thumb.png file (for
  backwards-compatibility with older plugins, or for plugins that have
  no suitable icon in FontAwesome)

  2. Third-party theme developers can still provide their own thumb.png
  files for the core blocktypes if they wish. They'll just need to place
  them under their own theme directory (i.e.
  /theme/CUSTOMTHEME/plugintypes/blocktype/clippy/images/thumb.png)

  So it won't have any effect on what third-party devs can do. It'll
  just remove some unused and unmaintained image files from the core
  Mahara distribution.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1532642/+subscriptions