← Back to team overview

mahara-contributors team mailing list archive

[Bug 1487306] A change has been merged

 

Reviewed:  https://reviews.mahara.org/5927
Committed: https://git.mahara.org/mahara/mahara/commit/f28384143abb93b4daa59a7b502c4ffaeea9bd96
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit f28384143abb93b4daa59a7b502c4ffaeea9bd96
Author: Mason Warring <corgifan2@xxxxxxxx>
Date:   Tue Jan 19 15:38:12 2016 +1300

Bug #1487306 Notifcations changed <h4> to a <div>

In the modified file, I changed the <h4> for the user's incoming
notfications into a div, because the <h4> was apparently causing issues
with the JAWS screen reader (can't verify if this has been fixed, as I
am on Linux), but with the <div> it works fine on Orca screen reader.

Added a css style to make the font-weight = 300 as it was before with
<h4> tag

behatnotneeded

Change-Id: Ia99262a579b4733b406c8b2e608d480b6cb47262

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487306

Title:
  Move the "select" checkbox out of item heading in Inbox

Status in Mahara:
  Fix Committed

Bug description:
  In the Inbox, all notifications have a "Select" checkbox as part of
  the panel header. This is wrapped in an <h4>, which causes screen
  readers such as JAWS to read out the checkbox strangely. It would be
  nice to make the panel header a <div> and have a heading inside it
  containing just the notification title.

  Affects latest master

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487306/+subscriptions


References