mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

Public bug reported:

Following on from Bug #1529731 I notice that there is a lot of
duplication of code / non-consistent use of the TITLE  / PAGEHEADING /
SUBSECTIONHEADING for pages.

There are many places where the TITLE - set as a defined value for a php
file is exactly the same as PAGEHEADING which is passed into $smarty
after the fact. It would be easier to allow the PAGEHEADING to be set as
TITLE if their is no overriding PAGEHEADING set.

I've also feel the SUBSECTIONHEADING should be set as a constant rather
than a $subsectionheading variable to keep it consistent with the other
ones.

For the setting of the PAGEHEADING and SUBSECTIONHEADING constants the order they appear in the <h1> tag was not consistent. Normally the values are set as:
SUBSECTIONHEADING = the particular instance title
PAGEHEADING = the umbrella title

For example, for a group's pages it is:
SUBSECTIONHEADING = Pages
PAGEHEADING = Group 1 (the name of the group)

Which displays as:
<h1>Pages | Group 1</h1>

So I'll make a few patches to clean this up

** Affects: mahara
     Importance: Medium
     Assignee: Robert Lyon (robertl-9)
         Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1539262

Title:
  Sorting out TITLE / PAGEHEADING / SUBSECTIONHEADING for pages

Status in Mahara:
  New

Bug description:
  Following on from Bug #1529731 I notice that there is a lot of
  duplication of code / non-consistent use of the TITLE  / PAGEHEADING /
  SUBSECTIONHEADING for pages.

  There are many places where the TITLE - set as a defined value for a
  php file is exactly the same as PAGEHEADING which is passed into
  $smarty after the fact. It would be easier to allow the PAGEHEADING to
  be set as TITLE if their is no overriding PAGEHEADING set.

  I've also feel the SUBSECTIONHEADING should be set as a constant
  rather than a $subsectionheading variable to keep it consistent with
  the other ones.

  For the setting of the PAGEHEADING and SUBSECTIONHEADING constants the order they appear in the <h1> tag was not consistent. Normally the values are set as:
  SUBSECTIONHEADING = the particular instance title
  PAGEHEADING = the umbrella title

  For example, for a group's pages it is:
  SUBSECTIONHEADING = Pages
  PAGEHEADING = Group 1 (the name of the group)

  Which displays as:
  <h1>Pages | Group 1</h1>

  So I'll make a few patches to clean this up

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1539262/+subscriptions