mahara-contributors team mailing list archive

[Mahara Bot <1515794@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5891
Committed: https://git.mahara.org/mahara/mahara/commit/ca9c4fbc90e3e90330f96ef0b14d9e06f04235fc
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    15.10_STABLE

commit ca9c4fbc90e3e90330f96ef0b14d9e06f04235fc
Author: Jean-Philippe Gaudreau <jp.gaudreau@xxxxxxxxxxxx>
Date:   Tue Jan 5 15:38:46 2016 -0500

Bug 1515794: Fixing incomplete phpunit database teardown

Table from plugin artefact.blog/blocktype:taggedposts wasn't deleted
because plugins inside an artefact were not retrieved in the uninstall
process.

behatnotneeded: Not related to the interface, only unit tests.

Change-Id: I82f5ca40f2e6b17869228aef0d81e21ba69ed675

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1515794

Title:
  phpunit database teardown is incomplete

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  As noticed in Bug 1515473.

  If you run the Mahara phpunit tests twice against the same database
  (by doing "make phpunit") you get errors on the second run. Phpunit
  attempts to tear down the test database and re-create it, but it
  misses some items and errors out when it tries to recreate them,
  because they already exist. This happens in Postgres or MySQL.

  I'm guessing it's because there are some database entities that we
  create through direct execution of DDL statements rather than through
  XMLDB and install.xml files. Probably the teardown uses the
  install.xml files to remove everything, misses the directly-created
  things, and then the subsequent installer tries to re-create them.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1515794/+subscriptions