← Back to team overview

mahara-contributors team mailing list archive

[Bug 1556692] A change has been merged

 

Reviewed:  https://reviews.mahara.org/6132
Committed: https://git.mahara.org/mahara/mahara/commit/b5df2226b4785193889bb71ae60d15054f9ceaf3
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit b5df2226b4785193889bb71ae60d15054f9ceaf3
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Mar 3 16:02:14 2016 +1300

Fix bug in xmlrpc + $cfg->usersuniquebyusername

Bug 1556692: When used together, these can cause problems when
the ID field from Moodle gets truncated to the default
get_new_username() length of "30", when being inserted into
usr.username in Mahara.

behatnotneeded: Can't test Mnet in Behat

Change-Id: Icdeb78b5298e7d63a0610987b0d8fad34e58d036

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1556692

Title:
  Problem with MNet usernames greater than 30 characters, when
  $CFG->usersuniquebyusername is used

Status in Mahara:
  Fix Committed
Status in Mahara 1.10 series:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  This bug occurs when the following set of circumstances are in use:

  1. MNet is set up, with users coming *into* Mahara
  2. Mnet is set to auto-create user accounts in Mahara
  3. $cfg->usersuniquebyusername is set to "True", which means that users are logged in by matching them against usr.username rather than auth_remote_user.remoteusername

  In this case, users coming from Mnet are provisioned in Mahara with a
  unique username based on their Moodle username, but truncated to 30
  characters. Then on subsequent login attempts, their truncated Mahara
  username doesn't match their Moodle username, and they do not log in
  correctly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1556692/+subscriptions


References