← Back to team overview

mahara-contributors team mailing list archive

[Bug 1557825] [NEW] Remove unused view.numcolumns database field

 

Public bug reported:

Spun off from Bug 1537861.

Prior to Mahara 1.8, the view.numcolumns field indicated how many
columns a view had, which was important because that's pretty much all
the page layout we had in Mahara 1.7 and earlier.

In Mahara 1.8 we moved to the more complicated "flexible layout" system,
where a page can have multiple rows, and each row can have a different
number of columns and column widths. With that in place, we stopped
using the view.numcolumns field.

However, the field stayed in the database for some reason, possibly just
overlooked or possibly for backwards compatibility. While working on Bug
1537861, Robert suggested that we should remove this column, because at
the moment it's vestigial and just makes things confusing for people
looking at the database and/or the code.

** Affects: mahara
     Importance: Low
     Assignee: Robert Lyon (robertl-9)
         Status: In Progress

** Changed in: mahara
    Milestone: None => 16.04.0

** Changed in: mahara
   Importance: Undecided => Low

** Changed in: mahara
       Status: New => In Progress

** Changed in: mahara
     Assignee: (unassigned) => Robert Lyon (robertl-9)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1557825

Title:
  Remove unused view.numcolumns database field

Status in Mahara:
  In Progress

Bug description:
  Spun off from Bug 1537861.

  Prior to Mahara 1.8, the view.numcolumns field indicated how many
  columns a view had, which was important because that's pretty much all
  the page layout we had in Mahara 1.7 and earlier.

  In Mahara 1.8 we moved to the more complicated "flexible layout"
  system, where a page can have multiple rows, and each row can have a
  different number of columns and column widths. With that in place, we
  stopped using the view.numcolumns field.

  However, the field stayed in the database for some reason, possibly
  just overlooked or possibly for backwards compatibility. While working
  on Bug 1537861, Robert suggested that we should remove this column,
  because at the moment it's vestigial and just makes things confusing
  for people looking at the database and/or the code.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1557825/+subscriptions


Follow ups