mahara-contributors team mailing list archive

[Mahara Bot <1545380@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6150
Committed: https://git.mahara.org/mahara/mahara/commit/c2b7e9203a6216be9edffe97bd138b55683468dd
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    15.10_STABLE

commit c2b7e9203a6216be9edffe97bd138b55683468dd
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Feb 15 13:49:23 2016 +1300

Bug 1545380: Profile images on user list broken for staff

When 'Staff report access' is set to 'no'. This is due to the column
being built from both the 'select' and 'icon' part of the $cols array.

So need to pass in a mostly blank 'select' column info rather than
unset it.

Also fixed up the missing right side line on button when viewing page as
staff with 'Staff report access' set to 'yes'

behatnotneeded

Change-Id: I97d77f0dc136967efa16945114bcd990e49754d0
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit b5bf4d5da0febd4916dc0b8d2eb71470760f0671)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1545380

Title:
  Profile pictures displayed incorrectly for staff on user search when
  no access list access

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  Mahara 15.10+

  When you are a staff member and don't have access to the access list
  (in Administration -> Configure site -> Site options -> User settings
  -> "Staff report access" set to "No", the user search page doesn't
  display the profile pictures correctly, but all next to each other
  (see attachment).

  It is fine when the setting is "yes" because then the "All/None"
  column is there.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1545380/+subscriptions