mahara-contributors team mailing list archive

[Mahara Bot <1537912@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5972
Committed: https://git.mahara.org/mahara/mahara/commit/51910ec55fd2e6e4efd39c4f9985a43b1639056e
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 51910ec55fd2e6e4efd39c4f9985a43b1639056e
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Jan 27 16:01:02 2016 +1300

Bug 1537912: Allow the 'login' link to show when sidebars exist

There was a setting to stop the login link (top right) from showing if
there were sidebars on logged out homepage. This became a problem if
the login box was turned off (not counted as a sidebar block for some
reason) via $cfg->showloginsideblock = false;

But the top right login link should always show when logged out
whether a sidebar is in play or not.

behatnotneeded

Change-Id: I8d6c1916f165285afb1f0210a0ae9b364f3a7a4f
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1537912

Title:
  No login link when "Links and resources" block is present

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  In Progress

Bug description:
  When you set the config value to

  $cfg->showloginsideblock = false;

  and you only see the "Login" link at the top rather than the standard
  login box, you don't see the link if you have publicly available
  "Links and resources".

  To replicate:
  1. Add $cfg->showloginsideblock = false; to your config file.
  2. You'll see that you only have a login link at the top right on the homepage and not the login block.
  3. Add a link to the "Links and resources" menu for "Public links and resources" at /admin/site/menu.php
  4. Log out. 

  Expected result: Still see the login link.
  Actual result: No login link. You'll need to go to /?login in order to log into your Mahara site.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1537912/+subscriptions