mahara-contributors team mailing list archive

[Mahara Bot <1523298@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6016
Committed: https://git.mahara.org/mahara/mahara/commit/dfbdc06714f1b0e89deefee8deb2f38735463d07
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    15.10_STABLE

commit dfbdc06714f1b0e89deefee8deb2f38735463d07
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Dec 7 13:32:10 2015 +1300

Bug 1523298: Make get_owner_object() return LiveUser object

This way we can avoid re-making it multiple times further down the
chain.

Most places where the get_owner_object() object was passed can handle
dealing with a User object vs a StdObject anyway.

behatnotneeded - existing tests should suffice

Change-Id: I2b92d9e408066a9c3b4c2f0bb87fbe8370bf9911
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 2bcebcd4bb1359f924a438742bafad0486e6dc5f)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1523298

Title:
  Unnecessary calls to new User object in can_view_view

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Slimming down the number of calls to new User/find_by_id() when we
  already have the User object being passed around

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1523298/+subscriptions