← Back to team overview

mahara-contributors team mailing list archive

[Bug 1559796] [NEW] If you close a form config via the "X" button on the modal, the form change checker doesn't get cleared

 

Public bug reported:

The "form change checker" is the Javascript system that we use to detect
unsaved changes in a form. If you make changes in a Mahara form and then
navigate away from the page without submitting or cancelling the form,
it shows a popup that says something like "This page is asking you to
confirm that you want to leave - data you have entered may not be
saved."

The bug here, is that on the page builder screen, you can either close a
block configuration modal window by hitting "Cancel" (or "Delete") on
the bottom of the form, or by clicking an "X" button in the upper-left
hand corner of the modal. If you make changes to the form and then hit
the "X" button, the form change checker doesn't get cleared, which means
that subsequently when you try to navigate away from the screen, you'll
see the warning message about unsaved changes.

To replicate:

1. Open a page for editing
2. Put a Text block into the page (or edit an existing text block)
3. Change the block's "Retractable" setting.
4. Click the "X" button in the upper-left of the modal
5. Press F5 to reload the page (or click a link to navigate to another page)

Expected result: You should not see a warning message, because you don't have any unsaved changes.
Actual result: You see the form change checker's warning message.

** Affects: mahara
     Importance: Low
         Status: Confirmed

** Affects: mahara/16.04
     Importance: Low
         Status: Confirmed

** Also affects: mahara/16.04
   Importance: Undecided
       Status: New

** Changed in: mahara/16.04
       Status: New => Confirmed

** Changed in: mahara/16.04
   Importance: Undecided => Low

** Changed in: mahara/16.04
    Milestone: None => 16.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1559796

Title:
  If you close a form config via the "X" button on the modal, the form
  change checker  doesn't get cleared

Status in Mahara:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed

Bug description:
  The "form change checker" is the Javascript system that we use to
  detect unsaved changes in a form. If you make changes in a Mahara form
  and then navigate away from the page without submitting or cancelling
  the form, it shows a popup that says something like "This page is
  asking you to confirm that you want to leave - data you have entered
  may not be saved."

  The bug here, is that on the page builder screen, you can either close
  a block configuration modal window by hitting "Cancel" (or "Delete")
  on the bottom of the form, or by clicking an "X" button in the upper-
  left hand corner of the modal. If you make changes to the form and
  then hit the "X" button, the form change checker doesn't get cleared,
  which means that subsequently when you try to navigate away from the
  screen, you'll see the warning message about unsaved changes.

  To replicate:

  1. Open a page for editing
  2. Put a Text block into the page (or edit an existing text block)
  3. Change the block's "Retractable" setting.
  4. Click the "X" button in the upper-left of the modal
  5. Press F5 to reload the page (or click a link to navigate to another page)

  Expected result: You should not see a warning message, because you don't have any unsaved changes.
  Actual result: You see the form change checker's warning message.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1559796/+subscriptions


Follow ups