← Back to team overview

mahara-contributors team mailing list archive

[Bug 1560131] Re: Mahara SAML auth broken with Simplesamlphp 1.14.x

 

This diff fixed logins and logouts on our server with SimpleSAMLPHP
1.14.2.

It appears that they've taken away the ability to query the
SimpleSAML_Session object for many parameters.  For example, instead of:

$saml_session->getIdP();

they want you to do:

$as->getAuthData('saml:sp:IdP');

I couldn't figure out a good way to replace ->getAuthority() so I moved
the code to figure out which SP to use above the logout functionality
and use that instead.  This is probably just because I don't work with
the SimpleSAMLPHP code enough to understand where that functionality
went.

Chris

** Attachment added: "saml_diff"
   https://bugs.launchpad.net/mahara/+bug/1560131/+attachment/4606731/+files/saml_diff

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1560131

Title:
  Mahara SAML auth broken with Simplesamlphp 1.14.x

Status in Mahara:
  New

Bug description:
  When attempting to use Mahara 15.10.1 on Ubuntu 14.04.4 with
  Simplesamlphp 1.14.x, I attempt to SSO login and get the error:

  PHP Fatal error:  Call to undefined method
  SimpleSAML_Session::getInstance() in
  /cluster/www/sites/secure.smus.ca/www/mahara/auth/saml/index.php on
  line 56

  This appears to be because the Simplesamlphp people removed the
  function call SimpleSAML_Session::getInstance() in version 1.14.0:

  https://simplesamlphp.org/docs/stable/simplesamlphp-upgrade-notes-1.14

  I looked at auth/saml/index.php and it doesn't look like there are too
  many times that $saml_session is used.  I'll see if I can figure out
  what to use in place of the $saml_session stuff.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1560131/+subscriptions


References