mahara-contributors team mailing list archive

[Mahara Bot <1560738@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6236
Committed: https://git.mahara.org/mahara/mahara/commit/d292c1c324b714713fc46a0ec7782c995a717059
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit d292c1c324b714713fc46a0ec7782c995a717059
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Wed Mar 23 13:09:14 2016 +1300

Fix SASS compile problem in cookieconsent

Bug 1560738: The problem was a URL starting with "//".
The fix is to surround it with single-quotes.

Change-Id: I8f3f761f99f7d5bb447897240b5c7185720e46b8
behatnotneeded: Covered by existing tests

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1560738

Title:
  SASS compilation error in cookieconsent 2.0.9

Status in Mahara:
  Fix Committed

Bug description:
  If you have the npm package gulp-sass at version 2.2.0 or later,
  compiling the latest master will cause an error to be displayed:

  Building CSS...
  [13:05:09] Using gulpfile ~/www/mahara-test/gulpfile.js
  [13:05:09] Starting 'css'...
  Compiling CSS for htdocs/theme/custom
  Compiling CSS for htdocs/theme/default
  Compiling CSS for htdocs/theme/modern
  Compiling CSS for htdocs/theme/ocean
  Compiling CSS for htdocs/theme/primaryschool
  Compiling CSS for htdocs/theme/raw
  Compiling CSS for htdocs/theme/subthemestarter
  Error in plugin 'sass'
  Message:
      htdocs/theme/raw/sass/cookieconsent.scss
  Error: Invalid CSS after "...n-name:slideUp}": expected ")", was ""
          on line 2 of stdin
  >> er;background-image:url(//cdnjs.cloudflare.com/ajax/libs/cookieconsent2/1.0.10
     ------------------------------------------^

  [13:05:14] Finished 'css' after 4.72 s

  This is due to a change in the cookieconsent SCSS file during the
  upgrade to CookieConsent 2.0.9 (Bug 1535519)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1560738/+subscriptions