← Back to team overview

mahara-contributors team mailing list archive

[Bug 1482384] A change has been merged

 

Reviewed:  https://reviews.mahara.org/5874
Committed: https://git.mahara.org/mahara/mahara/commit/61eb47060093f8f255542e6c8a160e2b428286cf
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 61eb47060093f8f255542e6c8a160e2b428286cf
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Jan 6 12:57:31 2016 +1300

Bug 1482384: Ingoring obsolete blocks when copying

If when copying a page it has a block on it where the underlying mahara php
files for the block are missing/unreadable it will be ignored (not
copied) rather than cause a fatal error.

behatnotneeded

Change-Id: Icca31baa3499db5956a1751f00541e2e667ed4f3
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1482384

Title:
  Need to fix copy page/collection where the original page has obsolete
  blocks

Status in Mahara:
  Fix Committed

Bug description:
  If a user has a page / collection that contains blocks for blocktype
  plugins that don't exist on the server anymore it causes the copying
  to fail as certain functions can't be found during the copying
  process.

  There needs to be a step where the copy process either:

  1) Not copy any plugin blocks where the plugin is not active, or

  2) Check to see if the version.php file still exists for the plugin
  first and not copy any blocks where it doesn't, or

  3) Have the table column that keeps track of the 'active' status of
  blocktype plugins to also have the option of '-1'  to indicate not
  active and also files missing (this info could also be displayed on
  the Admin -> Extensions screen as well) so that the copy process
  ignores blocks with active status = -1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1482384/+subscriptions


References