mahara-contributors team mailing list archive

[Mahara Bot <1332373@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6057
Committed: https://git.mahara.org/mahara/mahara/commit/240befff090020a134804a47a09a1b67f8b017f1
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 240befff090020a134804a47a09a1b67f8b017f1
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Fri Feb 12 15:36:50 2016 +1300

Bug 1332373: Add 19-character dbprefix limit to documentation

Based on the maximum database object name length in Postgres,
and the longest names of objects we're currently using, 19
characters is the hard limit. (Technically... 25 characters
for MySQL. But why confuse things?)

We're actively testing on test.mahara.org with a 19-character
db prefix, so I think it's safe to tell the users that they
can use one that long.

Change-Id: Id13ee82ca70780791870782b8465695366cee8eb
behatnotneeded: comment change only

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1332373

Title:
  Make it clear what the maximum length is for $cfg->dbprefix

Status in Mahara:
  Fix Committed

Bug description:
  Bug 1326205, in which MySQL installs would error out if there was a
  dbprefix present, has caused me to realize that we don't really have a
  set limit on maximum dbprefix length. Obviously, setting one that's
  too long, like "thisisareallyreallyreallyreallylongdbprefix" will
  cause the code to crash no matter what.

  It would probably be a good idea to decide on a maximum dbprefix
  length, and put this into the pre-install sanity check. (It doesn't
  need to be mentioned in the config-dist.php file, because most people
  are going to be reasonable and use something short.)

  For reference, MySQL has a limit of 64 characters for names of most
  things ( http://dev.mysql.com/doc/refman/5.1/en/identifiers.html ) and
  Postgres has a limit of 63 characters (because the "name" datatype is
  limited to 64 characters, one of which is used for a terminating null:
  http://www.postgresql.org/docs/8.3/static/datatype-character.html ).

  With some quick testing, I find that in 1.10dev, the max length I can
  use in mysql is 25 characters, and in postgres it's 19 characters. I'm
  not sure why there's such a big difference... presumably this is due
  to some objects being created in Postgres but not in MySQL?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1332373/+subscriptions