mahara-contributors team mailing list archive

Thread
Date

[Bug 1564681] [NEW] Rename the pre/post modal popup functions to be more generic

To: mahara-contributors@xxxxxxxxxxxxxxxxxxx
From: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date: Fri, 01 Apr 2016 00:30:59 -0000
Reply-to: Bug 1564681 <1564681@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

Public bug reported:

In js/views.js we have some functions that were originally for
hiding/showing media players.

Now that these functions are not just doing things for media players but
can be used for more things we should rename them to be more generic to
avoid confusion about what they are for.

It looks like they are only called in this file so changing them should
be easy enough.

I'm thinking of changing:
hideMediaPlayers() -> preModalOpen()
showMediaPlayers() -> postModalClose()

** Affects: mahara
     Importance: Low
         Status: Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1564681

Title:
  Rename the pre/post modal popup functions to be more generic

Status in Mahara:
  Confirmed

Bug description:
  In js/views.js we have some functions that were originally for
  hiding/showing media players.

  Now that these functions are not just doing things for media players
  but can be used for more things we should rename them to be more
  generic to avoid confusion about what they are for.

  It looks like they are only called in this file so changing them
  should be easy enough.

  I'm thinking of changing:
  hideMediaPlayers() -> preModalOpen()
  showMediaPlayers() -> postModalClose()

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1564681/+subscriptions