mahara-contributors team mailing list archive

[Mahara Bot <1566127@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6309
Committed: https://git.mahara.org/mahara/mahara/commit/d5aef398e98f747009b03ae0b15319ef7a47821c
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit d5aef398e98f747009b03ae0b15319ef7a47821c
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Tue Apr 5 16:04:47 2016 +1200

Use PHP 5.3 array syntax

Bug 1566127

Change-Id: I8e249a93fbff7c3bf914099e53f1f29068a36a15
behatnotneeded: Covered by existing tests

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1566127

Title:
  PHP 5.3 incompatible array declarations

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  In lib/graph.php there's a spot where an array is initialized using
  the easier array syntax introduced in PHP 5.4:

      $defaultcolours =
  ['187,35,39','59,140,46','61,132,203','227,171,0','0,74,136','139,62,138','220,109,10','29,183,197','116,116,116','62,35,110'];

  Since we're still supporting PHP 5.3, this needs to use the array()
  pseudo-function instead.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1566127/+subscriptions