← Back to team overview

mahara-contributors team mailing list archive

[Bug 1571910] [NEW] Missing cacheversion on upgrade gives errors

 

Public bug reported:

When upgrading from old version that doesn't have cacheversion set we
get this error

[WAR] 21 (lib/htmlpurifier/HTMLPurifier/Config.php:901) Value for
HTML.DefinitionRev is of invalid type, should be int invoked on line
3598 in file /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/web.php

It doesn't stop the upgrade from progressing, so I'll mark this bug as
low priority, but could freak user out when upgrading their sites.

It would be good to allow get_config() function to take a $default value
option, similar to how param_alpha() works.

This way we can set a default value before the upgrade sets the correct
value

So I'm thinking get_config('cacheversion', 0); would return value '0'
rather than false so that htmlpurifier does not complain but still
allows for the upgrade to set the cacheversion as expected.

** Affects: mahara
     Importance: Low
     Assignee: Robert Lyon (robertl-9)
         Status: In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1571910

Title:
  Missing cacheversion on upgrade gives errors

Status in Mahara:
  In Progress

Bug description:
  When upgrading from old version that doesn't have cacheversion set we
  get this error

  [WAR] 21 (lib/htmlpurifier/HTMLPurifier/Config.php:901) Value for
  HTML.DefinitionRev is of invalid type, should be int invoked on line
  3598 in file /home/robertl/htdocs/mahara-
  devel/mahara/htdocs/lib/web.php

  It doesn't stop the upgrade from progressing, so I'll mark this bug as
  low priority, but could freak user out when upgrading their sites.

  It would be good to allow get_config() function to take a $default
  value option, similar to how param_alpha() works.

  This way we can set a default value before the upgrade sets the
  correct value

  So I'm thinking get_config('cacheversion', 0); would return value '0'
  rather than false so that htmlpurifier does not complain but still
  allows for the upgrade to set the cacheversion as expected.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1571910/+subscriptions


Follow ups