mahara-contributors team mailing list archive

[Mahara Bot <1570744@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6372
Committed: https://git.mahara.org/mahara/mahara/commit/857af9058ed8a1298347f22fce675d0b0294cbf1
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    15.04_STABLE

commit 857af9058ed8a1298347f22fce675d0b0294cbf1
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Mon Apr 18 17:24:49 2016 +1200

Correcting typoes in cookie-issuing code

Bug 1570744: Accidentally used set_cookie() instead of
setcookie(). This makes the cookie break if you use
the $cfg->cookieprefix setting.

behatnotneeded: Covered by existing tests

Change-Id: Idec3676222e3ff4eb22f7925de6bec10cfa35755

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1570744

Title:
  Duplicate session headers not removed in PHP 5.3

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  See also Bug 1570179.

  It turns out that our method clear_duplicate_cookies() doesn't work in
  PHP 5.3, because the behavior of session headers is different there
  than in the versions of PHP we tested on. We need to rewrite the
  function to work properly in PHP 5.3, as long as we claim to support
  5.3.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1570744/+subscriptions