mahara-contributors team mailing list archive

[Mahara Bot <1567100@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6395
Committed: https://git.mahara.org/mahara/mahara/commit/c144fcfa1cc06a58af44a182a4e6605b96b6b022
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    1.10_STABLE

commit c144fcfa1cc06a58af44a182a4e6605b96b6b022
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Apr 7 09:58:36 2016 +1200

Bug 1567100: In Mahara we deal with username in a case insensitive way

In other places we check the LOWER(username) but for some reason
in find_by_username() we don't. We should do it here as well for
consistency.

behatnotneeded

Change-Id: Ie692aeace0c8aa2f6989683e094ac6625f153b98
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit fb330e38079d589146313bd70f64c4637bf40e48)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1567100

Title:
  $user->find_by_username is NOT case insensitive

Status in Mahara:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  The function find_by_username doesn't use LOWER(username) but the
  function find_by_instanceid_username() does

  We should be consistent and check find_by_username as lowercase as
  well

  See bug 684425 for related info

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1567100/+subscriptions