mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

Hi Darren

Thank you for spotting this mistake

I've added your patch to the review system
https://reviews.mahara.org/#/c/6401/1

Cheers

Robert

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1574716

Title:
  Fatal error in lib/form/elements/ratings.php

Status in Mahara:
  New

Bug description:
  When loading a portfolio in 16.04RC2, a white screen is encountered,
  and the following is written to the error log. This also occurred in
  16.04RC1.

  [25-Apr-2016 09:26:36] PHP Fatal error:  Can't use function return value in write context in /home/darren/public_html/m1604rc2/lib/form/elements/ratings.php on line 71
  [25-Apr-2016 09:26:36] PHP Stack trace:
  [25-Apr-2016 09:26:36] PHP   1. {main}() /home/darren/public_html/m1604rc2/view/view.php:0
  [25-Apr-2016 09:26:36] PHP   2. pieform() /home/darren/public_html/m1604rc2/view/view.php:221
  [25-Apr-2016 09:26:36] PHP   3. Pieform::process() /home/darren/public_html/m1604rc2/lib/mahara.php:4493
  [25-Apr-2016 09:26:36] PHP   4. Pieform->__construct() /home/darren/public_html/m1604rc2/lib/pieforms/pieform.php:161
  [25-Apr-2016 09:26:36] PHP   5. Pieform->include_plugin() /home/darren/public_html/m1604rc2/lib/pieforms/pieform.php:406

  This occurs on RHEL6, with PHP 5.3.3

  [darren@swiftly m1604rc2]$ php -v
  PHP 5.3.3 (cli) (built: Jul  3 2015 03:10:33) 
  Copyright (c) 1997-2010 The PHP Group
  Zend Engine v2.3.0, Copyright (c) 1998-2010 Zend Technologies
      with Xdebug v2.1.4, Copyright (c) 2002-2012, by Derick Retinas

  This can be resolved by removing the !empty() on lines 48, 58, and 71
  - see attached patch.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1574716/+subscriptions