mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #34533
[Bug 1539322] Re: Do we still need device detection?
Currently, device detection does two things:
1. Disables TinyMCE
2. Hides the "Portfolio -> Export" navigation tab
There is also code in htdocs/lib/web.php, in the smarty() function,
which looks at the results of device detection and puts them into some
Smarty template variables. But since 15.10, we no longer actually read
those Smarty variables, at least not in any of the core themes.
1. $HANDHELD_DEVICE
2. $MOBILE
3. $DROPDOWNMENU (to disable dropdown menus; in 15.10 we show them anyway)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1539322
Title:
Do we still need device detection?
Status in Mahara:
Triaged
Bug description:
Mahara 15.10 introduced Bootstrap. All themes are now responsive. When
I tested the "Deactivate device detection" functionality, I couldn't
see much of a difference when using the site. I did notice the content
chooser was displayed the start of the words instead of only showing
the icon on the "Edit page" screen.
I wonder if we can remove the custom device detection. You can enable
the user turning off device detection in Admin -> Config site -> User
settings -> Users can disable device detection. That then happens on
the account settings page.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1539322/+subscriptions
References