mahara-contributors team mailing list archive

[Mahara Bot <1575955@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6437
Committed: https://git.mahara.org/mahara/mahara/commit/67858c0077897d64b37fbf307ecccf6fc4eb6f00
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    16.04_STABLE

commit 67858c0077897d64b37fbf307ecccf6fc4eb6f00
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Apr 28 10:40:39 2016 +1200

Bug 1575955: fixing function signatures for PHP7

They need to  be consistent in PHP7 and include the parameter types.

behatnotneeded - existing tests are ok

Change-Id: I5d94ee53962a92db6faf3718e5a54f48ea31e367
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit c5eb6088ccdd6fa8bf3c67e0fdb8e5997dabbfc0)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1575955

Title:
  PHP7 compatibility problems with function parameters

Status in Mahara:
  Fix Committed
Status in Mahara 1.10 series:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  PHP 7 causes warnings about parameter TypeError

  We need to clean up some code to be consistent.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1575955/+subscriptions