mahara-contributors team mailing list archive

[Mahara Bot <1575969@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6409
Committed: https://git.mahara.org/mahara/mahara/commit/c3d7f4f658409e200ba22a208e770efb3584649e
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit c3d7f4f658409e200ba22a208e770efb3584649e
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Thu Apr 28 11:32:01 2016 +1200

PHP7 changes the type required for exception handler

Bug 1575969. In PHP7 some errors throw an Error object (to
the exception handler) instead of generating an error
(handled by the error handler). The official way to make
an exception handler that will work in PHP 5 & 7, is to
leave off the parameter's type declaration.

Change-Id: I5fc1c3765d5a311eb499d62915e676f8d9ee07a0
behatnotneeded: Covered by existing tests

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1575969

Title:
  PHP7 exception handler needs to accept Throwables

Status in Mahara:
  Fix Committed
Status in Mahara 1.10 series:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  One of the backwards-incompatible changes in PHP7 is that some errors
  throw an Error object, which will go to the user-defined exception
  handler rather than the user-defined error handler. So the exception
  handler needs to accept Throwable objects (the ancestor to both Error
  and Exception) instead of just Exception objects.

  http://php.net/manual/en/migration70.incompatible.php#migration70.incompatible
  .error-handling.set-exception-handler

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1575969/+subscriptions