mahara-contributors team mailing list archive

[Kristina Hoeppner <1534081@xxxxxxxxxxxxxxxxxx>]

** Changed in: mahara
       Status: Fix Committed => Fix Released

** No longer affects: mahara/16.04

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1534081

Title:
  Fullscreen button is missing in embedded Vimeo video

Status in Mahara:
  Fix Released
Status in Mahara 1.10 series:
  Fix Released
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released

Bug description:
  I've found a lengthy discussion concerning the disappearance of the
  fullscreen button on Vimeo forums, where many people are complaining
  that is stopped working recently on various platforms:
  https://vimeo.com/forums/help/topic:277610

  https://vimeo.com/forums/help/topic:277610#comment_13981805
  So here is a response from Vimeo from another forum.
  1. In the past, fallback options in the browser allowed some version of fullscreen to operate even when within frames.
  2. Within the last few weeks, updates to major browsers removed these fallback options. This caused the fullscreen button to fail when clicked. Vimeo videos would no longer enter fullscreen if they were placed within frames.
  3. Because the button wouldn’t work anyway, in the last few days our developers have now removed the fullscreen button from any players that are embedded within frames. To confirm, the button would have been broken even if displayed. So, whether the button was there or not, your viewers would not be able to enter fullscreen.

  The recommendation from Vimeo support is the following: https://vimeo.com/forums/help/topic:277610
  If your embedded video is missing the fullscreen button in the Player, your embed code is likely missing these three required fullscreen attributes: webkitallowfullscreen mozallowfullscreen allowfullscreen
  Our embed code includes these attributes by default, but if you have modified the embed code, or used another service to generate the embed code, it's possible these attributes are missing. An example of how the Vimeo embed code should appear is shown in the code block below.
  NOTE: If the Vimeo iframe embed code is placed within another iframe, that parent iframe must also include the same fullscreen attributes.
  Once these fullscreen attributes are included, the Player will display the fullscreen button again.
  <iframe src= "https://player.vimeo.com/video/137003356"; width="500" height="281" frameborder="0" webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe>

  The recommended code is exactly what we are using, but fullscreen does
  not work in Mahara, while it works in Moodle (in the same browsers).
  Mahara seems to be stripping the necessary attributes
  webkitallowfullscreen mozallowfullscreen allowfullscreen on page view,
  while they are in the embed code when I confugure the External media
  block.

  You can see an example in Mahara here https://mahara.org/user/lenkak/page-1 -- no fullscreen button
  Fullscreen working in Moodle here https://lenka.moodlecloud.com/ (you need to log in as guest) 

  In this example video the lack of the fullscreen button is not such a
  problem, because there is a link to Vimeo where you can watch the
  video in fullscreen, but our clients are using private videos
  restricted to the Mahara domain, so that can be played only when
  embedded in Mahara, not on Vimeo.

  I have tested Mahara 1.10.8, 15.10.2testing and mahara.org -- same
  problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1534081/+subscriptions