mahara-contributors team mailing list archive

[Mahara Bot <1531610@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5890
Committed: https://git.mahara.org/mahara/mahara/commit/c467b7d4e06d0caf719f816bfa0d7b82dd1f4b69
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit c467b7d4e06d0caf719f816bfa0d7b82dd1f4b69
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Jan 7 16:15:31 2016 +1300

Bug 1531610: Fixing up missed 'notes' page js pagination

behatnotneeded

Change-Id: Ie6b88396503d97422aa807d66105b644d36cac51
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1531610

Title:
  Clean up inconsistencies in the paginators

Status in Mahara:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Now that we have the paginators behaving with the same underlying code
  there has arisen some issues with the optional variables each
  paginator can use.

  These issues include:
  - pages using jump links opiton but not collections
  Need to make it consistent

  - Some places using limit per page from the get_account_preference($USER->get('id'), 'viewsperpage'); variable while other are set to the default 10 per page.
  Need to only use the account preference for portfolio/group/institution/site pages and not elsewhere
  Need to also have it so that if the page has less than 10 results to ignore the user preference

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1531610/+subscriptions